fix(wrangler): don't proxy localhost requests during dev#12516
Merged
edmundhung merged 2 commits intomainfrom Feb 11, 2026
Merged
fix(wrangler): don't proxy localhost requests during dev#12516edmundhung merged 2 commits intomainfrom
edmundhung merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 88594ca The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Claude finished @edmundhung's task —— View job Changeset ReviewReviewing changeset file(s) for this PR...
✅ All changesets look good The changeset
The changeset effectively communicates what was broken, how it's fixed, and important details about the new behavior. |
edmundhung
force-pushed
the
edmundhung/fix-proxy-localhost
branch
from
d54a982 to
e3adbd1
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
edmundhung
changed the title
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
|
Does this mean that proxy environment variables now work, or just that they don't crash? |
Member
Author
It should work. Just skip the proxy when a request is made against localhost. |
jamesopstad
approved these changes
Feb 11, 2026
Co-authored-by: James Opstad <[email protected]>
edmundhung
force-pushed
the
edmundhung/fix-proxy-localhost
branch
from
720903f to
88594ca
Compare
Merged
NuroDev
pushed a commit
that referenced
this pull request
Feb 11, 2026
Co-authored-by: James Opstad <[email protected]>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8906.
It looks like wrangler's proxy setup bleeds into miniflare's inspector proxy and should skip proxying requests to localhost. I considered scoping the proxy setup to the wrangler CLI only , but the Vite plugin also needs it for remote binding API calls.
This fix replaces
ProxyAgentwith undici'sEnvHttpProxyAgent, which natively supportsNO_PROXY. WhenNO_PROXYis not set, it defaults tolocalhost,127.0.0.1,::1, so local dev server requests are never proxied.The
NO_PROXYconfig only applies to the request destination, not the proxy server address. So a proxy running on localhost (e.g.,HTTP_PROXY=http://127.0.0.1:11451) still works for outbound API calls.vite devwith a non existentHTTP_PROXY(e.g.http_proxy=http://127.0.0.1:11451 vite dev)TypeError: fetch failed)A picture of a cute animal (not mandatory, but encouraged)